code-review-graph

In code-review-graph 2.3.8, _FRAMEWORK_DECORATOR_PATTERNS in flows.py does not recognize Java's @Override or JUnit/TestNG lifecycle annotations, so methods invoked by the JDK contract or test runner are incorrectly classified as dead.

Apply the fix from #1034, or manually add these patterns to _FRAMEWORK_DECORATOR_PATTERNS in flows.py:

re.compile(r"^Override$"),
re.compile(
    r"^(Test|Before|After|BeforeEach|AfterEach|BeforeAll|AfterAll"
    r"|BeforeClass|AfterClass|ParameterizedTest|RepeatedTest|TestFactory)$"
),

Then rebuild and rerun:

code-review-graph build --repo . --data-dir /tmp/dc-data
code-review-graph dead-code --repo . --data-dir /tmp/dc-data

The anchored Override pattern prevents unrelated annotations such as override_settings from matching. After the patch, hashCode() and @BeforeEach setUp() are no longer reported, while genuinely unused symbols remain flagged.

The files are being decoded with the Windows system locale encoding (usually cp1252) instead of UTF-8. Fix each open() call by explicitly passing encoding="utf-8"; keep errors="replace" only where partial output is preferred:

with open(path, encoding="utf-8", errors="replace") as f:
    source = f.read()

Apply this to tools/review.py, tools/flows_tools.py, context_savings.py, token_benchmark.py, eval/runner.py, and eval/reporter.py. The upstream fix is in PR #928, folded into #988 and merge 3030ca8; it will be included in the next release. As a temporary workaround on Windows, enable Python UTF-8 mode before running the tool:

set PYTHONUTF8=1

PowerShell:

$env:PYTHONUTF8 = "1"

This affects code-review-graph 2.3.8 on Windows. The stale-file purge selects old rows using their stored backslash paths, but normalizes them to POSIX paths before deletion, so nothing is deleted and the build inserts every node again.

Fix: upgrade to a release containing PR #988 (the fix was merged to staging and targeted for the release after 2.3.8), then rerun:

code-review-graph build --repo . --data-dir <your-data-dir>

The fixed build removes legacy rows using their exact stored spelling while preserving canonical POSIX rows.

If you cannot upgrade yet, rebuild into a fresh data directory instead of reusing the old one:

code-review-graph build --repo . --data-dir C:/tmp/graph-fresh

Verify the new database, then point your tooling at it or replace the old data directory. A successful exit code and normal Full build log line do not prove that duplication was avoided in 2.3.8.

This is a bug in code-review-graph 2.3.8. Python TESTED_BY edges may use a bare symbol name, while tests_for looks up a fully qualified path such as /abs/path/file.py::Class.method. The fallback compares absolute file paths against dotted Python module names like odoo.addons.module.file, so the import-evidence check fails and covered code is reported as uncovered.

Immediate workaround: use callers_of and identify callers marked is_test=True:

code-review-graph query callers_of "/abs/path/wizard_update_invoice_supplierinfo_line.py::WizardUpdateInvoiceSupplierinfoLine._prepare_supplierinfo_update"

Permanent fix: upgrade to a release containing the Python import-resolution fixes from PR #960/#988 and PR #997. If building from source, use a build that includes commits 3030ca8 and 9c13f4c, or build from staging until the fix is merged into main. The fix resolves dotted Python modules to their repository files before comparing import evidence, allowing the bare-name fallback to find the existing TESTED_BY edge.

This happens in code-review-graph 2.3.8 because the installed hook runs code-review-graph update without --repo. From a linked worktree, repository discovery resolves to that worktree and creates a new .code-review-graph database.

A fix is available on staging via PR #988 (merge 3030ca8) and will ship in the next release. The corrected hook passes --repo and skips automatic graph checks in linked worktrees unless CRG_HOOK_WORKTREES=1 is set. After upgrading, reinstall the hook:

code-review-graph install

Immediate workaround for 2.3.8:

1. Open the shared hook:

$(git rev-parse --git-path hooks/pre-commit)

2. Make it skip linked worktrees and explicitly target the main checkout:

#!/bin/sh
if command -v code-review-graph >/dev/null 2>&1; then
  if [ "$(git rev-parse --git-dir)" = "$(git rev-parse --git-common-dir)" ]; then
    code-review-graph update --repo /absolute/path/to/main-checkout || true
    code-review-graph detect-changes --brief --repo /absolute/path/to/main-checkout || true
  fi
fi

3. Remove databases already created inside worktrees:

rm -rf /path/to/worktree/.code-review-graph

As a one-off alternative, commit in the worktree with git commit --no-verify, then run code-review-graph update from the main working tree.